Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Column.simplified_type defaults

#4447

Hi all

This relates over to ticket #4270 Arel 0.3.2 broke non-standard column types where I've submitted a small patch to correct behavior on PostGIS for two additional column types. (geometry and geography)

But I wanted to also bring up that by default, if the Column doesn't have a type match it just throws back a nil. Is there a reason for no else at the end of the case statement as a measure of last resort?

In my case (and I would hazard to guess in a lot of others) defaulting to :string would solve the problem.

Reported by garrett · April 21st, 2010 @ 09:07 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. garrett
    garrett

    diff of the change I'm proposing above

    April 21st, 2010 @ 09:26 AM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Tag changed from activerecord rails3, 3.0, columns, postgres to activerecord rails3, 30, columns, postgres

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:43 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:43 PM