Rails Ruby on Rails → 2.1.1

Comments and changes to this ticket

• 

  Jeremy Kemper June 20th, 2008 @ 09:43 AM

  • Milestone set to “2.1.1”
  • State changed from “new” to “incomplete”

  Please extract to quote_database_name and add a test case.

• You flagged this item as spam.
  

  Roel van der Hoorn June 20th, 2008 @ 10:13 AM

  I'm unable to find existing tests relating to this functionality, but the following should test it I guess.

  def test_should_create_database_with_dot
    assert_nothing_raised do
      create_database("r.vanderhoorn")
    end
  end
  

• You flagged this item as spam.
  

  Irene August 20th, 2008 @ 06:14 PM

  • Tag set to “2.1, postgresql, quoting”

  Same with the drop database:

  
  def drop_database(name) #:nodoc:
    execute "DROP DATABASE IF EXISTS #{name}"
  end
  

  Should be:

  
  def drop_database(name) #:nodoc:
    execute "DROP DATABASE IF EXISTS \"#{name}\""
  end
  

• You flagged this item as spam.
  

  Roel van der Hoorn September 11th, 2008 @ 04:50 PM

  Looks like both issues were fixed in 2.1.1.

• 

  Jeremy Kemper September 11th, 2008 @ 04:52 PM

  • State changed from “incomplete” to “duplicate”