This project is archived and is in readonly mode.

incorrect comparation in form_options_helper.rb def option_value_selected?

#4638

Hi,
There is no selected option generated when active record use composite primary keys plugin.
The error is caused by incorrect comparison in following code.

def option_value_selected?(value, selected)
if selected.respond_to?(:include?) && !selected.is_a?(String)
selected.include? value
else
value == selected
end
end

The value has type "CompositePrimaryKeys::CompositeIds (1 element(s))" and it's not comparable to variable selected.

changing one line of the code to following solve the problem.

value.to_s == selected

Best regards
Krzysiek

PS
I'm RoR beginner, so the analyze could be wrong ;(

Reported by Krzysztof Kuczek · May 18th, 2010 @ 11:49 AM

Activity

Rizwan Reza
- No changes were found…
May 21st, 2010 @ 12:49 AM
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 04:38 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 04:38 PM

There was a problem

incorrect comparation in form_options_helper.rb def option_value_selected?

Activity