This project is archived and is in readonly mode.

Use better assertion methods for testing
Reported by Neeraj Singh | May 18th, 2010 @ 06:07 PM
Instead of using assert and assert_equal use assert_nil, assert_not_nil and other testing methods to make failure message more descriptive.
Patch will be attached through comment.
Comments and changes to this ticket
- 
         Neeraj Singh May 18th, 2010 @ 06:11 PM- Tag changed from rails3, test to patch, rails3, test
- Assigned user set to José Valim
 Attached is patch. 
- 
         
- 
         Neeraj Singh May 19th, 2010 @ 04:52 AMAs per my discussion with Santiago let's put this ticket on hold until I am able to cover rest of test cases. 
- 
         Repository May 19th, 2010 @ 09:21 AM- State changed from new to resolved
 (from [b4629528866446aa59f663a1162edbdacee85600]) Use better assertion methods for testing [#4645 state:resolved] Signed-off-by: José Valim jose.valim@gmail.com 
 http://github.com/rails/rails/commit/b4629528866446aa59f663a1162edb...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 
         4641 
          Use assert_instance_of whenever possible instead of assert
        This ticket can be closed. I am providing the patch throu... 4641 
          Use assert_instance_of whenever possible instead of assert
        This ticket can be closed. I am providing the patch throu...
- 
         4643 
          Use assert_kind_of whenever possible instead of assert
        This ticket can be closed. I am providing patch through #... 4643 
          Use assert_kind_of whenever possible instead of assert
        This ticket can be closed. I am providing patch through #...
- 
         4644 
          Use assert_respond_to because it has better error messaging
        This ticket can be closed. I am providing patch through #... 4644 
          Use assert_respond_to because it has better error messaging
        This ticket can be closed. I am providing patch through #...
- 
         4645 
          Use better assertion methods for testing
        [#4645 state:resolved] 4645 
          Use better assertion methods for testing
        [#4645 state:resolved]
 José Valim
      José Valim
 Neeraj Singh
      Neeraj Singh
 Santiago Pastorino
      Santiago Pastorino