This project is archived and is in readonly mode.

#4813 ✓stale

habtm _ids association with non numeric ids no longer allowed

Reported by lcars | June 9th, 2010 @ 06:13 PM


The pasted code (around line 1337 of lib /active_record/associations.rb in activerecord-2.3.8) prevents the usage of non numeric ids (which afaik is perfectly legal and used to work with previous version of AR) when doing the following: => 'foobar' :friend_ids => ["non_numeric_id"])

define_method("#{}_ids=") do |new_value|
ids = (new_value || []).reject { |nid| nid.blank? }.map(&:to_i) send("#{}=", reflection.klass.find(ids).index_by(&:id).values_at(*ids)) end

I think it's something that should be fixed. Otherwise advice is appreciated.


Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “open” to “stale”
  • Dmitry Polushkin

    Dmitry Polushkin February 5th, 2011 @ 02:05 AM

    I guess it now possible in Rails3.

            redefine_method("#{}_ids=") do |new_value|
              pk_column = reflection.primary_key_column
              ids = (new_value || []).reject { |nid| nid.blank? }
    !{ |i| pk_column.type_cast(i) }
              send("#{}=", reflection.klass.find(ids).index_by{ |r| }.values_at(*ids))

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket