This project is archived and is in readonly mode.

#4842 ✓wontfix
Luca Guidi

[PATCH] ActionDispatch MemCacheStore violates encapsulation principle

Reported by Luca Guidi | June 12th, 2010 @ 11:29 AM

When pass :cache param to ActionDispatch::Session::MemCacheStore, it should be removed from options, otherwise it remains "published". This violates the OOP encapsulation principle.

I attached a patch for this issue.

Comments and changes to this ticket

  • Michael Koziarski

    Michael Koziarski June 13th, 2010 @ 06:22 AM

    • State changed from “new” to “wontfix”

    We don't generally modify argument hashes otherwise it breaks code which uses a single hash passed to multiple constructors. e.g. 5.times { Whatever.new(@options) }

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages