This project is archived and is in readonly mode.

[Patch] insert_fixtures casts Time.now to string for timestamp_columns

#5019

insert_fixtures casts Time.now to string for timestamp_columns:

def insert_fixtures
    now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
    now = now.to_s(:db)

so, when saving the data to the database, these columns won't get quoted in the adapter by quoted_date.
So all tests running against a MS SQL Server database with non US local locale (e.g German) will fail due to the wrong datetime format.

Edited by Rohit Arondekar for formating.

Reported by kdgundermann · June 30th, 2010 @ 02:17 PM

Activity

kdgundermann
Patch in http://gist.github.com/458635

June 30th, 2010 @ 02:24 PM

kdgundermann

Some tests are still failing because the fixtures data uses #to_s(:db)
in pirates.yml

redbeard:
  catchphrase: "Avast!"
  parrot: louis
  created_on: <%= 2.weeks.ago.to_s(:db) %>
  updated_on: <%= 2.weeks.ago.to_s(:db) %>

June 30th, 2010 @ 09:58 PM

Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:01 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:01 PM