This project is archived and is in readonly mode.
Touch-ing with counter cache results in an erro
We have two models, one of 'things' and one of 'likes'
The relationship is :
Thing
has_many :likes
Like
belongs_to :thing, :counter_cache => :like_count, :touch => :true
If I then create a like against a thing the attached stack is returned with:
NoMethodError: undefined method true=' for
#<Thing:0x2b2c49df9788>
Removing :touch => :true from the Likes model makes the error go away, but then leaves your Thing model with a stale timestamp which is a bad thing.
This worked in all previous Rails 3.0 beta's but now appears to have changed.
-
backtrace.txt
8.87 KB
-
José Valim- Importance changed from to Low
Could you please add a failing test case to Rails test suite?
-
Neil MiddletonHi José,
I would love to, but am not sure how, and therefore can't be sure that the test would be correct.
N
-
Mark TurnerThis isn't a bug. When you use a symbol with :touch it attempts to update an attribute with that same name. He just needs to use :touch => true to update the updated_at field.
-
Neil Middleton
OK - had a stab at it - I've altered the models so that the issue causes some tests to fail.
-
5365_test.patch
1021 Bytes
-
-
Mark Turner
Here is a passing test using the correct syntax for touch.
-
touch-association-counter.patch
1.38 KB
-
-
Neil Middleton
@Mark it seems you're correct. In my app this is now working as it should. However, I'm not sure how this was previously working prior to rails3.0.0.rc
-
Mark Turner
@Niel, you did find a corner case we didn't have a test for.
-
Neil Middleton
@Mark - well, it's nice to make a rails contribution - no matter how small ;)
-
Mark Turner
- Tag changed from activerecord rails3, rails 3.0.0.rc, touch to activerecord rails3, rails 3.0.0.rc, patch, touch
-
Mark Turner
- Assigned user set to Santiago Pastorino
-
Mark Turner
- Title changed from Touch-ing with counter cache results in an error to Touch-ing with counter cache results in an erro
Any word on the test patch I added?
-
Repository- State changed from new to committed
(from [6177a0be96cebac129d0e20d2b5ec009a00fa56c]) added testcase for belongs_to with a counter_cache and touch
[#5365 Touch-ing with counter cache results in an erro state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/6177a0be96cebac129d0e20d2b5ec0... -
Repository
(from [f1b33f7f22b7cddb7a80afbfa134a62600391b22]) Restore pet -> owner relationship to the previous state
[#5365 Touch-ing with counter cache results in an erro] http://github.com/rails/rails/commit/f1b33f7f22b7cddb7a80afbfa134a6...
-
Repository
(from [6f478b06989ee10b63c9581b266b60bb946afd4f]) Restore pet -> owner relationship to the previous state
[#5365 Touch-ing with counter cache results in an erro] http://github.com/rails/rails/commit/6f478b06989ee10b63c9581b266b60...
-
Repository
(from [fc43c62fc68bc6a75fd57c2da252ede00dd319ba]) added testcase for belongs_to with a counter_cache and touch
[#5365 Touch-ing with counter cache results in an erro state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/fc43c62fc68bc6a75fd57c2da252ed...