This project is archived and is in readonly mode.
Script tag in prototype_helper rdoc causing formatting issue in API
In the doc body found here: http://github.com/rails/rails/blob/master/actionpack/lib/action_vie...
There is a script tag in the middle of a sentence (under class JavaScriptGenerator), just before the words "Ajax response bodies, either in a" and it is causing the documentation for this page to be ruined on the API, found here:
http://api.rubyonrails.org/classes/ActionView/Helpers/PrototypeHelp...
See screenshot.
-
Jeff KreeftmeijerI've included a patch that replaces every occurrence of
<script>with+script+in the ActionView::Helpers::PrototypeHelper RDocs.I wanted to escape the whole tag (including the "<" and ">"), but stuff like
+doesn't work. Is there any other way to do this? It could be fixed by doing something like @+<script>+@, but that would make it a lot less readable when reading the actual file instead of the generated RDocs.Thoughts? :)
-
rdoc_html_tag.diff
2.23 KB
-
-
David TrasboJeff,
Another option is to wrap
<script>in a<tt>tag. I've attached a patch that does just that - it also makes sure to wrap at 80 characters. -
-
justin
Thanks guys, so I guess your doc engine changed since it looks like that code doc with the SCRIPT tag has been there for a while.
-
Mark MulderIt looks like #5520 Online Rails 3 documentation has unescaped <script> tags is the same problem.
-
David Trasbo
- Assigned user set to Rohit Arondekar
Mark,
It is - the commit that #5520 Online Rails 3 documentation has unescaped <script> tags links to was created by me to resolve this ticket.
This too can be marked as resolved or duplicate.
-
Rohit Arondekar- State changed from new to duplicate
- Importance changed from to Low
-
Repository
(from [ddf73603c1aeb6be3fd8619c7c0054d4cd6528c8]) Backport of documentation fixes:
cfc8c7ab54173c4f28776a69de23028d771f6e24 dfebdb1b033c033b7a39615a39d9d4ac3052e61d
[#5520 Online Rails 3 documentation has unescaped <script> tags] [#5537 Script tag in prototype_helper rdoc causing formatting issue in API] [#5581 Session cookie not sent with activerecord or memcache store in Rails 2.3.9] http://github.com/rails/rails/commit/ddf73603c1aeb6be3fd8619c7c0054...