This project is archived and is in readonly mode.
Setting session and cookie variables in same request breaks session in following request in Rails 2.3.9
#5669
Think this might be related to #4743 Session Cookie breaks if used with custom cookie in rails 2.3.8
The problem is the same in that a newline is appended to the _session_id key and is thus causing the next request to create a new session.
Weirdly though I have not been able to replicate in a real application, but, only as part of IntegrationTest.
-
active_record_store_test.patch
1.09 KB
-
omarqureshiActually I lied, I did end up suffering from this in a real application just today.
-
omarqureshi
Attached is the previous test with a patch
-
omarqureshi
- Tag changed from rails 2.3.9, active_record_store, cookies, sessions to rails 2.3.9, active_record_store, cookies, patch, sessions
-
omarqureshi
This time updated with a properly formatted patch
-
sds- Tag changed from rails 2.3.9, active_record_store, cookies, patch, sessions to rails 2.3.10, rails 2.3.9, active_record_store, cookies, patch, sessions
+1 for this fix. The issue still exists in 2.3.10.
And not just for Active Record session store.
-
Aaron Patterson- State changed from new to committed
- Importance changed from to Low
I've applied this to the 2-3-stable branch. Thanks!
-
omarqureshi
Awesome - thank you!