Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

test/railties/engine_test.rb:91 fails

#5769

Test railties/test/railties/engine_test.rb fails:

Failure


test_engine_is_a_rack_app_and_can_have_his_own_middleware_stack(RailtiesTest::EngineTest)
[test/railties/engine_test.rb:91:in
test_engine_is_a_rack_app_and_can_have_his_own_middleware_stack'

/Users/codemanki/projects/misc/rails/activesupport/lib/active_support/testing/isolation.rb:65:in `run'
/Users/codemanki/projects/misc/rails/activesupport/lib/active_support/testing/isolation.rb:100:in `run_in_isolation'
/Users/codemanki/projects/misc/rails/activesupport/lib/active_support/testing/isolation.rb:97:in `fork'
/Users/codemanki/projects/misc/rails/activesupport/lib/active_support/testing/isolation.rb:97:in `run_in_isolation'
/Users/codemanki/projects/misc/rails/activesupport/lib/active_support/testing/isolation.rb:63:in `run']:

<["HELLO WORLD"]> expected but was
<["< html xmlns="http://www.w3.org/1999/xhtml">\n\n .... "]>

Problem

line 91: assert_equal ["HELLO WORLD"], response[2]
response[2] itself is an array.

Solution

Line 65
response[2][0].upcase!
Instead of
response[2].upcase!

Reported by codemanki · October 8th, 2010 @ 11:19 AM

State: resolved
Milestone: none
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. David Trasbo
    David Trasbo
    • State changed from new to open
    • Importance changed from to Low

    +1

    Patch applies cleanly to master and fixes the failing test.

    October 8th, 2010 @ 11:24 AM

  2. Rohit Arondekar
    Rohit Arondekar

    +1 nice catch, this is only on master and fixes the failing test.

    October 8th, 2010 @ 11:50 AM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to resolved

    Sorry i was going to apply it and was already fixed here e68c87bb

    October 8th, 2010 @ 06:32 PM