#5803 ActionView::Base.field_error_proc ignores label_tags with :class options - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5803 ✓stale

ActionView::Base.field_error_proc ignores label_tags with :class options

Reported by René | October 14th, 2010 @ 07:44 AM

Using this code block (see attached) to reformat label-tags, works fine, when using:

f.label :some_field

But when used like this:

f.label :some_field, :class=>'label'

it just skips the label tag without checking in field_error_proc.

I realised that the resulting html code looks like this:

<label class="label" for="....

After playing around I came up with a "workaround" by appending the class at the end, which suddenly made it working:

<%= f.label(:some_field).gsub('">', '" class="label">') %>

I guess field_error_proc is not working as intended.

Ryan Bigg October 19th, 2010 @ 08:30 AM
- Tag cleared.
- Importance changed from “” to “Low”
Automatic cleanup of spam.
Santiago Pastorino February 2nd, 2011 @ 04:47 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:48 PM
- State changed from “open” to “stale”