This project is archived and is in readonly mode.

ShowExceptions serves text/html even to XHR requests that don't accept it

#5890

The ActionDispatch::ShowExceptions middleware renders an HTML template without checking whether it's responding to XHR and the client accepts text/html.

Instead it should follow logic similar to Rack::ShowExceptions, which serves text/plain if:

  env["HTTP_X_REQUESTED_WITH"] == "XMLHttpRequest" && (!env["HTTP_ACCEPT"] || !env["HTTP_ACCEPT"].include?("text/html"))

The question is, what should the body contain in that case? Something like this?

 I18n.t('action_dispatch.rescue_responses.#{status_code}')

Reported by John Firebaugh · October 29th, 2010 @ 11:51 PM

Activity

Jeff Kreeftmeijer
- Importance changed from to Low
Automatic cleanup of spam.

November 1st, 2010 @ 05:02 PM
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 04:21 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 04:21 PM