This project is archived and is in readonly mode.
Revert deleted tests by past commit
Reported by Diego Carrion | March 4th, 2011 @ 07:24 PM
Hi, in this commit:
https://github.com/rails/rails/commit/080345baca1076a9788dff4803153...
some code was refactored and the tests deleted. I think the refactor was great, but the tests shouldn't have been deleted, as the validations still applies. This tests should be keep so the functionality is guaranteed independent of the implementation.
I attach a patch reverting only the tests part.
Comments and changes to this ticket
-
José Valim March 4th, 2011 @ 07:32 PM
- Assigned user changed from “José Valim” to “Santiago Pastorino”
- Importance changed from “” to “Low”
-
Santiago Pastorino March 4th, 2011 @ 08:11 PM
- State changed from “new” to “committed”
Pushed, well done manxa :P
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Diego Carrion
Jeremy Kemper
José Valim
Manfred Stienstra
Piotr Sarnacki
Santiago Pastorino