This project is archived and is in readonly mode.
auto_link fails to recognize urls separated by space
Reported by Eugene Pimenov | May 1st, 2008 @ 06:12 AM
>> helper.auto_link("http://test.org/ http://test.org/ http://test.org/")
=> "<a href=\"http://test.org/\">http://test.org/</a> http://test.org/ <a href=\"http://test.org/\">http://test.org/</a>"
Expected:
>> helper.auto_link("http://test.org/ http://test.org/ http://test.org/")
=> "<a href=\"http://test.org/\">http://test.org/</a> <a href=\"http://test.org/\">http://test.org/</a> <a href=\"http://test.org/\">http://test.org/</a>"
Comments and changes to this ticket
-
Eugene Pimenov May 1st, 2008 @ 06:04 AM
Hehe, lighthouse also triggers this bug:
http://test.org http://test.org http://test.org
-
-
Eugene Pimenov May 1st, 2008 @ 06:52 AM
http://dev.rubyonrails.org/ticke... another auto_link problem with patch
-
-
-
-
Repository May 16th, 2008 @ 01:03 PM
- State changed from “new” to “resolved”
(from [150717344aa5c6d8f46fc67de39d6947553ac286]) auto_link helper fails to recognize links separated by space. [#72 state:resolved]
Signed-off-by: Pratik Naik
-
Eugene Pimenov May 16th, 2008 @ 10:12 PM
nooooo =)
This version breaks another thing:
<a href="some url here">test;</a>
-
Pratik May 16th, 2008 @ 10:11 PM
- State changed from “resolved” to “open”
Do you have a failing test for that ? Feel free to catch me in #rails-contrib irc channel.
Thanks
-
Kevin Glowacz May 22nd, 2008 @ 05:59 PM
- State changed from “open” to “resolved”
Here is a failing test for what (what I think) Eugene was talking about:
assert_equal '<a href="http://google.com">Google</a>', auto_link('<a href="http://google.com">Google</a>') -
Kevin Glowacz May 22nd, 2008 @ 06:02 PM
I have no idea why it just marked this as resolved with my last comment.
-
Pratik May 22nd, 2008 @ 07:43 PM
- State changed from “resolved” to “open”
-
Kevin Glowacz May 22nd, 2008 @ 08:32 PM
here is a patch that fixes the original bug but doesn't break already linked urls
-
-
Repository May 22nd, 2008 @ 09:12 PM
- State changed from “open” to “resolved”
(from [1a73e98660b29a2ce9eccd5b0776367a4969a012]) Fix auto_link helper for already linked urls. [#72 state:resolved]
Signed-off-by: Pratik Naik
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Eugene Pimenov
Kevin Glowacz
Pratik
Stephen Celis