Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Changeset [5d43977c7c76a76adfffdafa3de2e739216dab81] by Murray Steele

Revision 5d43977c7c76a76adfffdafa3de2e739216dab81, committed by Murray Steele · March 23rd, 2011 @ 09:34 PM

Make clearing of HABTM join table contents happen in an after_destory callback.

The old method of redefining destroy meant that clearing the HABTM join table would happen as long as the call to destroy succeeded. Which meant if there was a before_destroy that stopped the instance being destroyed using normal means (returning false, raising ActiveRecord::Rollback) rather than exceptional means the join table would be cleared even though the instance wasn't destroyed. Doing it in an after_destroy hook avoids this and has the advantage of happening inside the DB transaction too.
https://github.com/rails/rails/commit/5d43977c7c76a76adfffdafa3de2e...

1 changed file

  • M activerecord/lib/active_record/associations.rb