This project is archived and is in readonly mode.

Changeset [6d30002a52133bd105adb29084f4cc72b1ee847f] by Pratik Naik

January 21st, 2010 @ 09:07 PM

Revert "Refactoring attributes/types" [#3348 state:open]

This reverts commit f936a1f100e75082081e782e5cceb272885c2df7.

Conflicts:

activerecord/lib/active_record.rb
activerecord/lib/active_record/base.rb

Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open]

This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3.

Reason :

It's not generating attribute methods properly, making object.column 5x slower. http://github.com/rails/rails/commit/6d30002a52133bd105adb29084f4cc...

Committed by Pratik Naik

  • R activerecord/lib/active_record/attributes.rb
  • R activerecord/lib/active_record/attributes/aliasing.rb
  • R activerecord/lib/active_record/attributes/store.rb
  • R activerecord/lib/active_record/attributes/typecasting.rb
  • R activerecord/lib/active_record/types.rb
  • R activerecord/lib/active_record/types/number.rb
  • R activerecord/lib/active_record/types/object.rb
  • R activerecord/lib/active_record/types/serialize.rb
  • R activerecord/lib/active_record/types/time_with_zone.rb
  • R activerecord/lib/active_record/types/unknown.rb
  • R activerecord/test/cases/attributes/aliasing_test.rb
  • R activerecord/test/cases/attributes/typecasting_test.rb
  • R activerecord/test/cases/types/number_test.rb
  • R activerecord/test/cases/types/object_test.rb
  • R activerecord/test/cases/types/serialize_test.rb
  • R activerecord/test/cases/types/time_with_zone_test.rb
  • R activerecord/test/cases/types/unknown_test.rb
  • R activerecord/test/cases/types_test.rb
  • M activerecord/lib/active_record.rb
  • M activerecord/lib/active_record/attribute_methods/before_type_cast.rb
  • M activerecord/lib/active_record/attribute_methods/query.rb
  • M activerecord/lib/active_record/attribute_methods/read.rb
  • M activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb
  • M activerecord/lib/active_record/attribute_methods/write.rb
  • M activerecord/lib/active_record/base.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>