Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Changeset [b2d94322e6f2c2324154465147938ca8b16c610d] by Xavier Noria

Revision b2d94322e6f2c2324154465147938ca8b16c610d, committed by Xavier Noria · March 27th, 2011 @ 07:45 PM

fixes a couple of regexps, the suite showed warnings about them

A couple of things worth mentioning here:

  • "{" is a metacharacter, should be escaped if it is meant to match a "{". The code worked, though, because the regexp engine is tolerant to this, but issued warnings.

  • gsub accepts a string as first argument. That's the best idiom to use when your pattern has no metacharacters, since gsub interprets the string as an exact substring to look for, rather than a regexp. The benefit is that your pattern is crystal clear and needs no backslashes. https://github.com/rails/rails/commit/b2d94322e6f2c2324154465147938...

1 changed file

  • M actionpack/lib/action_view/template/resolver.rb