Activity (RSS)

(from [cff2291df5d1df106ae8cf116655f0703f53f8c3]) Fix failing tests on mysql 4.1 & ruby 1.8.4. [#237 state:resolved]

Signed-off-by: Pratik Naik

http://githu...

Two more test failures: older versions of mysql require that decimal values be quoted, & ruby 1.8.4 formats timezones as +0500 instead of +05:00

(from [c2036adf7658f56c924e2a206731ee63b628f34f]) Show rails version when the server starts. [#235 state:resolved]

Signed-off-by: Pratik Naik

http://github....

+1 I've wanted this functionality. Looks great to me!

Could you please use git-format-path ?

Thanks.

(from [4e084c3d9860c31fca21395c13031f04bb510b15]) Add Rails.version. [#236 state:resolved]

Signed-off-by: Pratik Naik

http://github.com/rails/rails/co...

This small patch adds Rails.version which just calls Rails::VERSION::STRING. I think it's much nicer to look at and remember, and it goes well with the other R...

(from [314e556e6fb7278e37f6105fedbe5fc51f7f848a]) Parentheses should be acceptable characters for auto_link_urls. [#234 state:resolved]

Signed-off-by: Pratik ...

Sorry it took so long :)

Here is the new patch as requested. I hope I did everything right.

I don't quite remember what was the bug I fixed, but it didn't af...

(from [dd9938a44ee3a7bb6c42527a1be6fcec70bf4772]) Fix mysql 4.1 incompatibility in the active record schema tests.

Signed-off-by: Michael Koziarski

[#233 st...

+1, tested patch and looks good. Nice job on your first submission!

Currently, the regular expression used in auto_link_urls and, by association, auto_link, does not allow for parentheses in URLs.

While this is not a very comm...

Tiny patch which outputs the rails version when starting the server.

I am now convinced that this is the problem, i.e. rake db:test:clone results in integer columns that were originally created without an explicit limit in the m...

Actually this does not seem to be fixed. I am running into this issue as well:

When I run "rake db:test:clone" in Rails 2.0.991, it now creates foreign key in...

@Roger that is what it's doing, it's only used as a backup

@Pratik the test was in the wrong dir, I've attached two new files: one with the test, one with the...

I wonder if it couldn't use something like

if is_a?(klass) or is_a?(eval(klass)) # only use the eval as a backup...

-R

Yes I noticed.

1. The tests pass even without the patch. Also, the patch is in wrong directory. Should be in ar/test/cases/

2. Not really in favor of putting...

@Pratik : I suggest you look closer at my patch. It actually takes care of NOT showing the error message, something that ticket #189 does not do.

Duplicate of http://rails.lighthouseapp.com/p...

Mysql 4.1 does not support "SHOW FIELDS FROM xxx where yyyy". This patch works around that.

Committed with a minor change.

Thanks.

(from [262d23d763c05bbe5f433a99cb9f02e48a8cdd4a]) ActiveRecord::Base#reload should clear dirty attributes. [#231 state:resolved]

Signed-off-by: Pratik Naik

...

Currently, calling reload on a model does not clear the attribute changes:

product.name = "foo"
product.changed? # => true
product.reload
product.changed? ...

with the latest Edge rails ApplicationController is loaded twise

once from actionpack/lib/action_controller/dispatcher.rb:18

require_dependency 'application...

(from [6e3521e6134e7f0d0b27834266e41354290c4e7e]) Improve check_box_checked? to use include? for Array values. [#193 state:resolved]

Signed-off-by: Pratik Nai...

Thanks for answering.

Attached you can find a i386-msvcrt-compiled older version (0.7.1) of the postgres-driver. With this version any database activity will ...

this initial patch actually caused problems with gem:unpack / gem:install, unless you use code from the unpack_command.rb in rubygems to do a search prior to r...

Oops, sorry, that patch was bad. Please use this one.

I ran into this problem under MySQL 5.0.51b. Attached is a patch which checks the mysql version in the test and acts accordingly.

@Ryan Bates: adding the method to create_table and change_table is not so simple. Those take a TableDefinition, which is just that, a list of columns to be cre...

@Lawrence Pit: that's a good idea, but it doesn't work if I have non-standard associations (different foreign keys or table names). I guess edge cases would ha...

I'd also like to add that the tests look good, and firing the callbacks on the model before the observers seems to be the right thing to do.

+1. Looks good to me.

While extracting some behavior from a model callback to an observer, I discovered that observers are notified before model callbacks are fired. I expected the ...

Removing "patch" keyword.

Thanks.

(from [19d7b1d22bd68af00244ddc3e1f35cec187e9120]) Verbose ActiveRecord::AssociationTypeMismatch exception message. [#189 state:resolved]

http://github.com/rai...

I would like to add some thoughts on this topic.

Combining/composing/through'ing named_scopes would be nice to have indeed, but I would like to mention that t...