This project is archived and is in readonly mode.
datetime_select to accept :ampm option
-
Geoff BuesingSeems like a common enough need; I'd like to see it in core.
-
Yong Bakos- Tag changed from activerecord, enhancement, helper, patch to activerecord, enhancement, helper, patch
Glad to see your support. I hope to have this ready by the end of the month (that thing called 'work' always gets in the way).
-
Yong Bakos
Just an update. No progress on this patch yet.
-
JeffI would love to see this implemented.
-
Jeff
incidentally, http://code.google.com/p/rails-t... seems to work fine with 2.1. Haven't tested it against edge
-
Pratik- State changed from new to incomplete
-
Pratik
- Assigned user set to Geoff Buesing
-
Eric MillI hope this doesn't fall off a cliff; 12-hour time is the way of things in the West, its lack is glaring.
-
-
Elliot WinklerThe rails-twelve-hour-time plugin linked to above also works in 2.3. You could probably start with that.
-
Daniel Tsadok
True but it seems like it belongs in core, since it's such a common use case. Also, if you set prompt => true, Rails 2.3 gives a translation error for the prompt for AM/PM.
-
Yong Bakos
I am now (finally) actively working on this. Please stay tuned.
-
Geoff Buesing
Any updates on this?
-
Yong Bakos
Sorry, but no. (professional obligations are in my way)
-
Chad Jolly+1
I did a demo of an app today and the one 24hr time select was the glaring sticking point with the users. Kinda funny. As a quick fix I used some jQuery. Here's the snippet if anyone is interested:
http://gist.github.com/368952Hi Yong.
-
Yuval
+1 I'd like to see this implemented in core as well. I think there's a large enough user base that needs to user a 12-hour format (i.e. doesn't intuitively understand military time) that it should exists as an option under datetime_select.
-
Neeraj SinghI started working on patch for this issue. However because of inconsistencies between select and select methods I was not able to make a good patch. I opened another ticket #4432 datetime_select and select_datetime inconsistent for various options .
Now that #4432 datetime_select and select_datetime inconsistent for various options is resolved, I will take another shot at this one.
-
-
Trevor Turk- Importance changed from to
Just a quick thanks to Chad Jolly for the jQuery workaround. I'll keep an eye on this ticked in case anything else comes around, but I'm happy enough for now. Thanks :)
-
Matt ToddHere's a patch for multiparameter_attributes to support a 7th attribute with am/pm.
WIP. Needs accompanying changes to the datetime/time select helpers.
Why does 12am/pm have to be lame? :(
-
rails- State changed from incomplete to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale
-
Aditya Sanghi
If someone is still keen, I built this functionality and sent a pull request on Github. Please see https://github.com/rails/rails/pull/343
