This project is archived and is in readonly mode.
Re-add to_xml to ActiveResource
The method #encode doesn't work on an instance of ActiveResource having other ActiveResource instances in it's attributes.
Example:
@mum = Parent.find(1)
@mum.attributes = {"name" => "Mum","children"=> [#<Parent::Child:0x405e8cc ...>,#<Parent::Child:0x405e8cc ...>]}
@mum.name = "Mom"
@mum.save
# => RuntimeError Exception: Not all elements respond to to_xml
Solution:
re-add #to_xml to ActiveResource::Base
-
readd_to_xml.diff
1.63 KB
-
Michael Koziarski- Tag changed from activeresource, bug, patch, tested to activeresource, bug, patch, tested
- Milestone cleared.
-
rbpandeyCreated a test and fixed this issue. Please have a look.
-
Daniel SchierbeckHi rbpandey.
I've had a quick look at your patch, and it seems like you're using tabs instead of two spaces to indent your code. I believe the Rails coding guidelines say that you've got to use the latter style.
Otherwise the patch looks good -- please do fix this and resubmit!
-
-
-
Pratik- Assigned user set to Pratik
- State changed from new to incomplete
Patch is missing the documentation.
Thanks.
-
Cody Fauser
Patch updated with documentation for encoding() and to_json().
-
Wesley Moxam+1
Looks good!
-
Repository
- State changed from incomplete to resolved
(from [f2c10f27565318b5efbdc57fb608b2afe9ae445d]) Add ActiveResource::Base#to_xml and ActiveResource::Base#to_json methods. [#1011 Re-add to_xml to ActiveResource state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...