From 8bed551c87efdc3df14c8e5987d28e227061127d Mon Sep 17 00:00:00 2001
From: Bob Aman <bob@sporkmonger.com>
Date: Wed, 28 Jan 2009 15:43:15 -0500
Subject: [PATCH] Invalid Location header values no longer cause exceptions.

---
 activeresource/lib/active_resource/base.rb |    2 +-
 activeresource/test/base_test.rb           |   15 ++++++++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/activeresource/lib/active_resource/base.rb b/activeresource/lib/active_resource/base.rb
index 54dde43..e012abb 100644
--- a/activeresource/lib/active_resource/base.rb
+++ b/activeresource/lib/active_resource/base.rb
@@ -1006,7 +1006,7 @@ module ActiveResource
 
       # Takes a response from a typical create post and pulls the ID out
       def id_from_response(response)
-        response['Location'][/\/([^\/]*?)(\.\w+)?$/, 1]
+        (response['Location'] || "")[/\/([^\/]*?)(\.\w+)?$/, 1]
       end
 
       def element_path(options = nil)
diff --git a/activeresource/test/base_test.rb b/activeresource/test/base_test.rb
index d37a6d4..e22388f 100644
--- a/activeresource/test/base_test.rb
+++ b/activeresource/test/base_test.rb
@@ -627,6 +627,12 @@ class BaseTest < Test::Unit::TestCase
     assert_equal '1', p.__send__(:id_from_response, resp)
   end
 
+  def test_id_from_response_without_location
+    p = Person.new
+    resp = {}
+    assert_equal nil, p.__send__(:id_from_response, resp)
+  end
+
   def test_create_with_custom_prefix
     matzs_house = StreetAddress.new(:person_id => 1)
     matzs_house.save
@@ -670,7 +676,6 @@ class BaseTest < Test::Unit::TestCase
     assert_equal person, person.reload
   end
 
-
   def test_create
     rick = Person.create(:name => 'Rick')
     assert rick.valid?
@@ -687,6 +692,14 @@ class BaseTest < Test::Unit::TestCase
     assert_raises(ActiveResource::ResourceConflict) { Person.create(:name => 'Rick') }
   end
 
+  def test_create_without_location
+    ActiveResource::HttpMock.respond_to do |mock|
+      mock.post   "/people.xml", {}, nil, 201
+    end
+    person = Person.create(:name => 'Rick')
+    assert_equal nil, person.id
+  end
+
   def test_clone
     matz = Person.find(1)
     matz_c = matz.clone
-- 
1.5.4.5