This project is archived and is in readonly mode.
Using the highlight helper on text with html shouldn't highlight text inside html attributes
#1302
This patch prevents the highlight text helper from highlighting text within html attributes.
ex without patch:
highlight('Rails was featured in a new <a href="http://example.com/blog/rails">blog post</a> today.', "rails")
#=> '<strong class="highlight">Rails</strong> was featured in a new <a href="http://example.com/blog/<strong class="highlight">rails</strong>">blog post</a> today.'
-
html_highlight.diff
3.23 KB
-
Tom BriceThis allows the use of #highlight on arbitrary HTML without breaking it
-
Pratik- Milestone cleared.
- Assigned user set to Pratik
- Title changed from [PATCH] Using the highlight helper on text with html shouldn't highlight text inside html attributes to Using the highlight helper on text with html shouldn't highlight text inside html attributes
-
Repository- State changed from new to resolved
(from [91eeb0ff119d34d0fcdb44d3d7fcbb7924208e05]) Using the highlight helper on text with html shouldn't highlight text inside html attributes. [#1302 Using the highlight helper on text with html shouldn't highlight text inside ... state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...