This project is archived and is in readonly mode.

#1371 ✓resolved
Will Bryant

Small construct_finder_sql refactor to support plugins

Reported by Will Bryant | November 13th, 2008 @ 10:34 PM | in 2.x

We don't have functionality like (for example) lazy-loading of BLOB and TEXT columns in core, nor excluding things like search vector pseudo-columns.

Rather than add this functionality to core, I'd like to make a very small refactor to construct_finder_sql that moves the ""/"my_table." default select strings out to a separate method, default_select, which can then be cleanly overriden in plugins without needing to copy in the entire construct_finder_sql method to the plugin.

Because it's such a small refactor, it's pretty safe. It changes only the defaults, all explicit select arguments & scopes still override it. Unless anyone can suggest a superior approach, could this please be considered for inclusion in 2.2?

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by