Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

send_file(..., :xsendfile => true) sets ETag though it shouldn't

#1578

send_file(..., :xsendfile => true) sets the ETag header to "7215ee9c7d9dc229d2921a40e899ec5f", regardless of which file is being sent. It should either set a proper ETag, or not set one at all. The latter is probably better for performance reasons.

Note that send_file(..., :xsendfile => false) doesn't set an ETag, as it should.

Reported by Hongli Lai · December 15th, 2008 @ 07:58 PM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Hongli Lai
    Hongli Lai

    Patch.

    December 15th, 2008 @ 08:36 PM

  2. Repository
    Repository
    • State changed from new to committed

    (from [9e2b4a10f7f091868b3c3701efb4c04048455706]) Do not output an ETag header if response body is blank or when sending files with send_file(... :xsendfile => true) [#1578 send_file(..., :xsendfile => true) sets ETag though it shouldn't state:committed]

    Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...

    December 16th, 2008 @ 11:30 AM