#1703 text_area_tag sanitize_to_id - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1703 ✓resolved

text_area_tag sanitize_to_id

Reported by sanderson (at nexttesting) | January 6th, 2009 @ 05:45 PM | in 2.x

text_area_tag('item[description]') should set id to "item_description" instead of "item[description]".

The unsanitized id with brackets fails HTML validation.

This is fixed by the attached simple patch file, which sets id to sanitize_to_id(name), instead of just name.

Test included.

Matt Jones January 7th, 2009 @ 03:10 AM
- Tag changed from “html, sanitize_to_id, validation” to “html, patch, sanitize_to_id, validation”
+1 - looks reasonable to me. Matches existing behavior and tests for other *_tag helpers.
José Valim January 7th, 2009 @ 03:45 PM
Agreed. +1
You flagged this item as spam.
Angel N. Sciortino (angelic) January 8th, 2009 @ 03:26 PM
It makes sense to me, and the test looks good.
You flagged this item as spam.
Tim Cartwright January 8th, 2009 @ 03:50 PM
This bug bit me when validating generated forms using the W3C’s HTML markup validator. Having a bug like this causes lots of error messages, making it difficult to see if there are other, more critical HTML errors. Plus, Rails just ought to generate clean HTML, IMO.
You flagged this item as spam.
Chris Mear February 20th, 2009 @ 03:41 PM
- Tag changed from “html, patch, sanitize_to_id, validation” to “html, patch, sanitize_to_id, validation, verified”
+1 Makes sense -- makes it consistent with other FormTagHelper methods, and test looks good.
Michael Koziarski June 9th, 2009 @ 09:37 AM
- State changed from “new” to “resolved”
applied

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>