This project is archived and is in readonly mode.
Remove transaction queries from assert_queries count.
In testing some functionality with transactions, I noticed that assert_queries works inconsistent with sqlite vs mysql.
A sqlite transaction would produce 1 query and mysql 3, because mysql uses the BEGIN and COMMIT keywords. This patch removes those keywords from the queries before comparing.
Note: Other db's might need similar adjustment, but these are my database flavours.
-
assert_queries.diff
1 KB
-
Manfred StienstraEloy's commit without the question in the commit message.
-
Manfred Stienstra
Tests for assert_queries.
-
Eloy DuranMoved the removal of the transaction queries to helper.rb and added test for not counting SHOW FIELDS FROM.
-
Eloy Duran
- Assigned user set to Michael Koziarski
-
-
Santiago Pastorino- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale