From 5acc13d6742a402354a85698cc26b47213d59d70 Mon Sep 17 00:00:00 2001 From: Rob Christie Date: Mon, 19 Jan 2009 01:24:13 -0500 Subject: [PATCH] Modified tests to pass with the Oracle adapter. A blank string is treated as null by Oracle, so two tests were failing inadvertently for Oracle. --- .../associations/belongs_to_associations_test.rb | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/activerecord/test/cases/associations/belongs_to_associations_test.rb b/activerecord/test/cases/associations/belongs_to_associations_test.rb index 40a8503..40351d0 100644 --- a/activerecord/test/cases/associations/belongs_to_associations_test.rb +++ b/activerecord/test/cases/associations/belongs_to_associations_test.rb @@ -383,35 +383,35 @@ class BelongsToAssociationsTest < ActiveRecord::TestCase assert_raise(ActiveRecord::ReadOnlyRecord) { companies(:first_client).readonly_firm.save! } assert companies(:first_client).readonly_firm.readonly? end - + def test_polymorphic_assignment_foreign_type_field_updating # should update when assigning a saved record sponsor = Sponsor.new member = Member.create sponsor.sponsorable = member assert_equal "Member", sponsor.sponsorable_type - + # should update when assigning a new record sponsor = Sponsor.new member = Member.new sponsor.sponsorable = member assert_equal "Member", sponsor.sponsorable_type end - + def test_polymorphic_assignment_updates_foreign_id_field_for_new_and_saved_records sponsor = Sponsor.new saved_member = Member.create new_member = Member.new - + sponsor.sponsorable = saved_member assert_equal saved_member.id, sponsor.sponsorable_id - + sponsor.sponsorable = new_member assert_equal nil, sponsor.sponsorable_id end def test_save_fails_for_invalid_belongs_to - assert log = AuditLog.create(:developer_id=>0,:message=>"") + assert log = AuditLog.create(:developer_id=>0,:message=>"Test log") log.developer = Developer.new assert !log.developer.valid? @@ -421,7 +421,7 @@ class BelongsToAssociationsTest < ActiveRecord::TestCase end def test_save_succeeds_for_invalid_belongs_to_with_validate_false - assert log = AuditLog.create(:developer_id=>0,:message=>"") + assert log = AuditLog.create(:developer_id=>0,:message=>"Test log") log.unvalidated_developer = Developer.new assert !log.unvalidated_developer.valid? -- 1.5.4.3