Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

fix remote_function url escaping

#180

The remote_function helper builds a JS call to Ajax.Update, but does not escape single quotes in the URL, leading to broken JavaScript if the URL has a single quote in it. This patch simply adds a test and fixes the bug.

Reported by André Arko · May 13th, 2008 @ 07:59 AM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Brian Donovan
    Brian Donovan

    +1

    May 13th, 2008 @ 02:35 PM

  2. Brad Greenlee
    Brad Greenlee

    +1. Simple fix.

    May 13th, 2008 @ 02:34 PM

  3. Pratik
    Pratik
    • State changed from resolved to new

    Made use escape_javascript() helper method instead of the regexp in your patch.

    Thanks.

    May 13th, 2008 @ 06:34 PM

  4. Pratik
    Pratik
    • State changed from new to resolved

    May 13th, 2008 @ 06:35 PM