This project is archived and is in readonly mode.
fix remote_function url escaping
Reported by André Arko | May 13th, 2008 @ 07:59 AM
The remote_function helper builds a JS call to Ajax.Update, but does not escape single quotes in the URL, leading to broken JavaScript if the URL has a single quote in it. This patch simply adds a test and fixes the bug.
Comments and changes to this ticket
-
-
-
Pratik May 13th, 2008 @ 06:34 PM
- State changed from “resolved” to “new”
Made use escape_javascript() helper method instead of the regexp in your patch.
Thanks.
-
Pratik May 13th, 2008 @ 06:35 PM
- State changed from “new” to “resolved”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
André Arko
Brad Greenlee
Brian Donovan
Pratik
Repository
Attachments
Tags
Referenced by
-
2500
remote_function does not allow dynamically generation of url
In ticket #180 the helper escape_javascript was introduce...