From ce8b8ea3b9f8c7f7fa175202c567f1aecb0cea5f Mon Sep 17 00:00:00 2001 From: rizwanreza Date: Sat, 8 Aug 2009 17:27:57 +0300 Subject: [PATCH] include_blank for select_tag --- .../lib/action_view/helpers/form_tag_helper.rb | 3 +++ actionpack/test/template/form_tag_helper_test.rb | 12 ++++++++++++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/actionpack/lib/action_view/helpers/form_tag_helper.rb b/actionpack/lib/action_view/helpers/form_tag_helper.rb index 1abe777..51bcf28 100644 --- a/actionpack/lib/action_view/helpers/form_tag_helper.rb +++ b/actionpack/lib/action_view/helpers/form_tag_helper.rb @@ -79,6 +79,9 @@ module ActionView # # def select_tag(name, option_tags = nil, options = {}) html_name = (options[:multiple] == true && !name.to_s.ends_with?("[]")) ? "#{name}[]" : name + if blank = options.delete(:include_blank) + option_tags = "" + option_tags + end content_tag :select, option_tags, { "name" => html_name, "id" => sanitize_to_id(name) }.update(options.stringify_keys) end diff --git a/actionpack/test/template/form_tag_helper_test.rb b/actionpack/test/template/form_tag_helper_test.rb index 7900426..338c326 100644 --- a/actionpack/test/template/form_tag_helper_test.rb +++ b/actionpack/test/template/form_tag_helper_test.rb @@ -135,6 +135,18 @@ class FormTagHelperTest < ActionView::TestCase input_elem = root_elem(select_tag("project[1]people", "")) assert_match VALID_HTML_ID, input_elem['id'] end + + def test_select_tag_with_blank + actual = select_tag "places", "", :include_blank => true + expected = %() + assert_dom_equal expected, actual + end + + def test_select_tag_with_blank + actual = select_tag "places", "", :include_blank => "string" + expected = %() + assert_dom_equal expected, actual + end def test_text_area_tag_size_string actual = text_area_tag "body", "hello world", "size" => "20x40" -- 1.6.2.2