Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Documentation Error in example: link_to_function

#2059

I found the following example doesn't work:


  link_to_function("Show me more", nil, :id => "more_link") do |page|
    page[:details].visual_effect  :toggle_blind
    page[:more_link].replace_html "Show me less"
  end

It returns the error: 'TypeError: Effect[klass] is not a constructor' Changing the syntax to the following works for me:


  link_to_function("Show me more", nil, :id => "more_link") do |page|
    page.visual_effect :toggle_blind, "details"
    page[:more_link].replace_html "Show me less"
  end

Incidentally, if you wish to use 'toggle_slide'. An Additional element (e.g. div) is required inside the element to be toggled. For example:


  link_to_function("Show me more", nil, :id => "more_link") do |page|
    page.visual_effect :toggle_slide, "details"
    page[:more_link].replace_html "Show me less"
  end

<div id="details" style="display:none">
  <div>
    These are the details.
  </div>
</div>

This example still fails in 2.3

Reported by Joff Williams · February 24th, 2009 @ 04:54 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Jason
    Jason

    +1 on this ticket. The solution provided above works correctly, and the note about the extra div also should be noted in the documentation.

    February 12th, 2010 @ 11:53 AM

  2. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:41 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:41 PM