This project is archived and is in readonly mode.
Unpack gems into vendor exactly once
Some gems apparently are packed oddly, with (for example) all files set to read-only. (Hoe is one - thanks ssoroka!)
This causes problems, as the 2.2 gem unpack code will unpack dependencies more than once.
The attached patch is more careful with dependencies; it will only unpack each gem once. This should fix issues that some users have been having with gems:unpack:dependencies.
-
unpack-gems-once.patch
3.09 KB
-
Steven Soroka+1 :D
-
Pratik- Assigned user set to Pratik
-
Pratik
Shouldn't we have tests for this ? Also, I think dependencies() should take an options hash instead of a boolean true/false.
Thanks.
-
-
Matt JonesWorking up a new patch, but I've got a question: A test for this is going to be hard to arrange. By design, gems already in vendor/gems aren't unpacked. So either there's going to be an external dependency, or a whole lot of mocking. Any ideas?
I'm incorporating the options hash; so dependencies(true) => dependencies(:flatten => true).
-
Matt Jones
- Milestone cleared.
I've attached a new patch. It cleans up the logic significantly by moving the decision to unpack into GemDependency#unpack_to, rather than scattered over the rake tasks.
-
unpack-gems-once-v2.patch
3.08 KB
-
Repository
- State changed from new to resolved
(from [a3ac1e1621506a6519b265ef6ec6abc70f6c8a27]) Display gem dependencies correctly and unpack exactly once [#2097 Unpack gems into vendor exactly once state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...