This project is archived and is in readonly mode.
Missing controller under test should mention ActionController::TestCase
If I'm testing a controller with a non-conforming test case name, and I forget to spec the controller class, the error message is misleading. (Example: PagesControllerAdminActionsTestCase.)
"@controller is nil: make sure you set it in your test's setup method."
We want to point people towards ActionController::TestCase, not the setup method, correct? Something like "@controller is nil: use ActionController::TestCase#tests(controller_class) or make sure you set it in your test's setup method."
That's a bit wordy. I'd prefer to drop the whole "setup method" business, but TestProcess could be invoked in a legacy test that is still using the setup message.
-
kdgundermann- Tag changed from 2.3, action_controller, testing to 2.3, action_controller, patch, testing
+1 Really helped me understanding the error message
-
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2.3, action_controller, patch, testing to 23, action_controller, patch, testing
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale