This project is archived and is in readonly mode.
SQLite / SQLite3 ActiveRecord Adapter should quote table names when renaming tables
-
Brian Hogan
- Tag set to 2.3.2, activerecord, patch, sql, sqlite, sqlite3
Here's a patch with tests that resolves the issue. I've seen this come up for quite some time now and finally figured out how to write appropriate tests. Anyone wanna review this and apply it? :)
-
Brian Hogan
How about we try this again with a patch that uses the quote_table_name mechanism instead of just single quotes? :)
-
Brian Hogan
- Title changed from ActiveRecord should quote table names to SQLite / SQLite3 ActiveRecord Adapter should quote table names when renaming tables
Changed title to make this more descriptive
-
Brian Hogan
Thanks to tpope for noticing my tests sucked - Patch with better tests.
-
Repository
(from [b26c2c11ab47dbd4d1e26806d1e861edc7d697e0]) Ensure table names are quoted while renaming for sqlite3 adapter [#2272 SQLite / SQLite3 ActiveRecord Adapter should quote table names when renaming ... state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/b26c2c11ab47dbd4d1e26806d1e861... -
Repository
(from [6d74e9d0b431e2487b498e4532bb1d8edcafa855]) Ensure table names are quoted while renaming for sqlite3 adapter [#2272 SQLite / SQLite3 ActiveRecord Adapter should quote table names when renaming ... state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/6d74e9d0b431e2487b498e4532bb1d...
