Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Fix 2.3.2 tag?

#2280

I noticed a message in this ticket:

http://rails.lighthouseapp.com/p...

That mentions the 2.3.2 tag being incorrect, while the gem version is OK.

This is making it more difficult to freeze an app to the "official" 2.3.2 release, since I'm not sure which commit that's based on, or how to get at it.

Any chance we can fix that tag or create a new one? Maybe a new branch for 2-3-stable would be good enough?

Thanks!

Reported by Trevor Turk · March 17th, 2009 @ 11:17 PM

State: resolved
Milestone: 2.x
Assigned to: DHH DHH
Importance: none

Activity

  1. Luigi Montanez
    Luigi Montanez

    This wreaked havoc for me in production. Without those Rack commits in there, all POSTed params were getting blanked out by Rails.

    Please fix ASAP so others don't have to suffer.

    March 18th, 2009 @ 03:06 PM

  2. Luigi Montanez
    Luigi Montanez

    The major problem is that the .tar.gz archive on dev.rubyonrails.org appears to use the tag to create the archive, so it's inconsistent with the gem release. As it now, the archive release contains the nasty bug described above since it doesn't include Rack 1.0.

    March 18th, 2009 @ 03:19 PM

  3. Pratik
    Pratik
    • Assigned user set to DHH

    March 18th, 2009 @ 03:56 PM

  4. CancelProfileIsBroken
    CancelProfileIsBroken
    • Assigned user cleared.

    I just downloaded the rails-2.3.2.tar.gz from http://rubyforge.org/frs/?group_..., and that copy does contain the fix to rack loading path from 18eb80ccc7e932f9a6c00462ceaeea648631b120 . That's where the link at http://rubyonrails.org/download sends you for standalone packages. Are you seeing something else?

    March 18th, 2009 @ 04:09 PM

  5. Luigi Montanez
    Luigi Montanez

    Yes, the Rubyforge version is correct.

    What isn't correct is this version:

    http://dev.rubyonrails.org/archi...

    Which is what is called when doing:

    rake rails:freeze:edge RELEASE=2.3.2

    from a Rails app.

    March 18th, 2009 @ 04:13 PM

  6. Trevor Turk
    Trevor Turk

    I'm not sure about RubyForge, but github looks wrong to me.

    This tag:

    http://github.com/rails/rails/co...

    ...doesn't include some commits:

    http://github.com/rails/rails/co...

    ...that I've been lead to believe:

    http://rails.lighthouseapp.com/p...

    ...are included in the gem, but not the tagged version.

    I'm not sure what impact having the tag on github not match the gem. I'm reporting it because I'm used to being able to freeze my production apps to a tag and/or a stable branch.

    March 18th, 2009 @ 04:17 PM

  7. CancelProfileIsBroken
    CancelProfileIsBroken

    Right, we know that Github tag doesn't match the gem, and the impact this has on freezing edge. Those issues will be corrected soonish. Just wanted to confirm that there wasn't yet another copy floating around somewhere.

    Until then, use the gem or grab edge straight from GitHub.

    March 18th, 2009 @ 04:29 PM

  8. CancelProfileIsBroken
  9. DHH
    DHH
    • State changed from new to resolved

    Added 2.3.2.1 as a fixed tag.

    March 18th, 2009 @ 04:32 PM

  10. Trevor Turk
    Trevor Turk

    That's great - thanks very much for the quick fix!

    March 18th, 2009 @ 04:33 PM