Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Seems like there is a bug in bolded block, or i don't understend logic of it's creators.

#2296

# File vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb, line 518
518:       def current_page?(options)
519:         url_string = CGI.escapeHTML(url_for(options))
520:         request = @controller.request
521:         # We ignore any extra parameters in the request_uri if the 
522:         # submitted url doesn't have any either.  This lets the function
523:         # work with things like ?order=asc 
524:         **if url_string.index("?") **
525:            **request_uri = request.request_uri**
526:          **else **
527:           **request_uri = request.request_uri.split('?').first**
528:          **end**
529:         if url_string =~ /^\w+:\/\//
530:           url_string == "#{request.protocol}#{request.host_with_port}#{request_uri}"
531:         else
532:           url_string == request_uri
533:         end
534:       end

Reported by Freiwillen · March 19th, 2009 @ 01:26 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Joe Yates
    Joe Yates

    The call to split (line 527) was replaced in this commit: http://github.com/rails/rails/commit/5e0a05b8cb236d285ebb45de006dd3...
    The code now seems correct.

    April 14th, 2010 @ 04:55 PM

  2. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:53 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:53 PM