Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Improve class counts for 'rake stats'

#2299

I've noticed that 'rake stats' does not a very good job of counting classes that have been reopened. I tend to use namespacing and inner classes quite a lot when writing Ruby so I end up with files like...


# some_lib/widget/helpers.rb
module SomeLib
  class Widget
    module Helpers
    ...
    end
  end
end

# some_lib/widget/extra_cool_stuff.rb
module SomeLib
  class Widget
    class ExtraCoolStuff
    ...
    end
  end
end

CodeStatistics would currently count SomeLib and SomeLib::Widget twice. This patch tries to do a better job of counting classes by using indentation within a file as a guide to namespace nesting. It also counts the number of modules and prints this in the output.

Reported by James · March 19th, 2009 @ 05:13 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x
    • Tag changed from railties, rake, stats, task to patch, railties, rake, stats, task

    May 4th, 2010 @ 06:48 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:40 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:40 PM