#2463 Add first and last to OrderedHash - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2463 ✓wontfix

Add first and last to OrderedHash

Reported by John | April 9th, 2009 @ 04:36 AM | in 3.x

When we upgraded our app from 2.1 to 2.3 the change in OrderedHash to be based on a hash rather than an array broke some of our code.

This patch adds first and last back onto the ordered hash - just for convenience's sake.

Comments and changes to this ticket

You flagged this item as spam.
James April 9th, 2009 @ 05:39 AM
Very handy indeed. Good to get this functionality back.
You flagged this item as spam.
Brian Hogan April 9th, 2009 @ 06:44 AM
+1 just because of uniformity. Like .each or .collect.
You flagged this item as spam.
Gareth Adams April 15th, 2009 @ 08:58 AM
This is a useful patch, +1

I was planning to open a bug report about OrderedHash#to_a not returning ordered results, maybe this is a better place for it?
You flagged this item as spam.
John April 15th, 2009 @ 09:00 AM
I can add this to the patch if you like?
You flagged this item as spam.
John April 16th, 2009 @ 12:28 AM
and now an ordered to_a method is included as well
- add_first_last_and_to_a_to_ordered_hash.diff 3.1 KB
You flagged this item as spam.
John April 16th, 2009 @ 12:29 AM
- Tag set to “verified”
You flagged this item as spam.
John May 12th, 2009 @ 01:48 AM
hey just pinging this ticket, it's been tagged verified for near a month
David Trasbo April 14th, 2010 @ 07:40 PM
- Assigned user set to “Ryan Bigg”
Regular hashes are ordered in Ruby 1.9, so I think this ticket should be marked as "won't fix" - in my opinion it serves no purpose to keep maintaining a piece of functionality that is available in newer versions of Ruby by default.

If people want OrderedHash to behave differently they can patch it on a per-app basis - or just upgrade.
Ryan Bigg April 15th, 2010 @ 11:03 AM
- State changed from “new” to “verified”
- Assigned user cleared.
If 3 people want a ticket it should be made into Rails unless Core vetos it. NOT marking as invalid, but rather verified so it should get some eyes.
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Rizwan Reza May 16th, 2010 @ 07:30 PM
- Tag changed from “verified” to “bugmash-review”
The patch didn't apply cleanly and also implemented to_a.

The patch attach applies cleanly, passes all tests and only implements first and last, as there is an implementation of to_a there now.
- 0001-adds-first-and-last-to-ordered-hash.patch 1.6 KB
Rizwan Reza May 16th, 2010 @ 07:39 PM
- Tag cleared.
- State changed from “verified” to “wontfix”
José replied:

OrderedHash behaves like a Hash now to be more close to Ruby 1.9 behavior. Since 1.9 we don't have #first and #last, OrderedHash shouldn't as well.