This project is archived and is in readonly mode.

#2509 ✓stale
Balint Erdi

mailer generator parameter inconsistency

Reported by Balint Erdi | April 16th, 2009 @ 10:35 AM | in 3.x

If I want to create a mailer called UserMailer (in a file called user_mailer.rb) currently I have to write:

./script/generate mailer user_mailer ...

The generated view directory and file names also do not have the mailer suffix appended which is -in my opinion- not very logical. Even more so since when I create a controller I do it with:

./script/generate controller user ...

and not

./script/generate controller user_controller

So what I propose is to have the _mailer suffix appended to file and directory names and the Mailer suffix appended to class names. So then the following files will be created:

  exists  app/models/
  create  app/views/user_mailer
  exists  test/unit/
  create  test/fixtures/user_mailer
  create  app/models/user_mailer.rb
  create  test/unit/user_mailer_test.rb
  create  app/views/user_mailer/signup.erb
  create  test/fixtures/user_mailer/signup
  create  app/views/user_mailer/delete_account.erb
  create  test/fixtures/user_mailer/delete_account

See patch attached that does just this.

Comments and changes to this ticket

  • Aitor García Rey
  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:03 PM

    • State changed from “new” to “open”
    • Tag changed from 2.x, mailer, patch to 2x, mailer, patch
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:03 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Pages