Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

add branch/tag option for 'script plugin/install' with git

#257

Being able to install plugins from git is a great start, but it would be even nicer if it supported a couple of options like --tag so i could do this:

script/plugin install git://github.com/dchelimsky/rspec.git --tag 1.1.4

Reported by David Chelimsky · May 26th, 2008 @ 11:36 PM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. qoobaa
    qoobaa

    This patch uses old --revision (-r) argument to specify revision of plugin when installing from git. We can specify revision by adding:

    • branch name e.g. 'experimental' (or full 'refs/heads/experimental')
    • tag name e.g. 'tag 1.8.0' (or full 'refs/tags/1.8.0')

    It uses git pull instead of git clone (see in git-pull(1) for more details).

    June 10th, 2008 @ 02:03 AM

  2. qoobaa
    qoobaa

    For clarity example above:

    June 10th, 2008 @ 02:10 AM

  3. qoobaa
    qoobaa

    ./script/plugin install --revision 'tag 1.1.4' git://github.com/dchelimsky/rspec.git

    P.S. Sorry for another comment, I can't edit previous.

    June 10th, 2008 @ 02:11 AM

  4. qoobaa
    qoobaa
    • Title changed from add branch option for 'script plugin/install' with git to add branch/tag option for 'script plugin/install' with git

    June 10th, 2008 @ 02:15 AM

  5. Les Hill
    Les Hill
    • Tag set to enhancement, patch, tested

    +1

    July 12th, 2008 @ 02:40 PM

  6. Clemens Kofler
    Clemens Kofler
    • Tag changed from enhancement, patch, tested to enhancement, patch, plugins, tested

    +1 (although plugins should be replaced by gems anyway).

    July 12th, 2008 @ 06:01 PM

  7. Les Hill
    Les Hill
    • Assigned user set to Pratik
    • Tag changed from enhancement, patch, plugins, tested to enhancement, patch, tested

    July 13th, 2008 @ 02:27 PM

  8. Tim Pope
    Tim Pope

    +1, though the "git_command" abstraction doesn't really serve any purpose

    July 14th, 2008 @ 02:54 AM

  9. Tim Pope
    Tim Pope

    Here's an ever so slightly altered version of Jakub's patch that cleans up the archaic git_command indirection and also avoids leaving an empty directory behind on failure.

    July 14th, 2008 @ 03:32 AM

  10. Repository
    Repository
    • State changed from new to resolved

    (from [5c086070824bf7dd2bc4c9ce97956d82ac3fa206]) Make script/plugin install -r option work with git based plugins. [#257 state:resolved]

    Signed-off-by: Pratik Naik

    http://github.com/rails/rails/co...

    July 14th, 2008 @ 03:52 AM

  11. Ryan Bigg
    Ryan Bigg
    • Tag cleared.

    Automatic cleanup of spam.

    October 9th, 2010 @ 10:04 PM

  12. Jeff Kreeftmeijer
  13. Aditya Sanghi
    Aditya Sanghi
    • Title changed from Add magic encoding comment to generated files to add branch/tag option for 'script plugin/install' with git
    • Assigned user cleared.

    October 24th, 2010 @ 02:42 PM

  14. bingbing