From a903bed0db042a9d58a48f12dc6b60ac5a233287 Mon Sep 17 00:00:00 2001 From: Ken Collins Date: Mon, 11 May 2009 19:24:44 -0400 Subject: [PATCH] Reimplement Fixtures.identify so that it consistently generates ids across ruby platforms. --- activerecord/lib/active_record/fixtures.rb | 3 ++- activerecord/test/cases/fixtures_test.rb | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/activerecord/lib/active_record/fixtures.rb b/activerecord/lib/active_record/fixtures.rb index c650111..21df277 100644 --- a/activerecord/lib/active_record/fixtures.rb +++ b/activerecord/lib/active_record/fixtures.rb @@ -1,6 +1,7 @@ require 'erb' require 'yaml' require 'csv' +require 'zlib' require 'active_support/dependencies' require 'active_support/test_case' @@ -528,7 +529,7 @@ class Fixtures < (RUBY_VERSION < '1.9' ? YAML::Omap : Hash) # be a positive integer, and will always be the same for a given # label, assuming the same OS, platform, and version of Ruby. def self.identify(label) - label.to_s.hash.abs + (Zlib.crc32(label.to_s)-2000000000).abs end attr_reader :table_name, :name diff --git a/activerecord/test/cases/fixtures_test.rb b/activerecord/test/cases/fixtures_test.rb index 252bf4f..8d2f4fc 100644 --- a/activerecord/test/cases/fixtures_test.rb +++ b/activerecord/test/cases/fixtures_test.rb @@ -517,6 +517,12 @@ class FoxyFixturesTest < ActiveRecord::TestCase def test_identifies_symbols assert_equal(Fixtures.identify(:foo), Fixtures.identify(:foo)) end + + def test_identifies_consistently + assert_equal 1546044661, Fixtures.identify(:s) + assert_equal 356372769, Fixtures.identify(:foo) + assert_equal 1846562493, Fixtures.identify(:some_longer_fixture_key) + end TIMESTAMP_COLUMNS = %w(created_at created_on updated_at updated_on) -- 1.6.1