This project is archived and is in readonly mode.
ability to set image as input type in submit_to_remote
Reported by gautam chekuri | May 23rd, 2009 @ 12:58 PM | in 3.x
- I noticed that the method call, to submit_to_remote, given
below, while seemingly valid, wasn't working since the method
button_to_function in actionpack/lib/action_view/helpers/ javascript_helper.rb was forcing the type to button.
<%=
submit_to_remote(
'update_resource_img',
'Update Resource 2',
:url => { :controller => 'hello', :action => 'update' },
:before => "$('loading').style.display = 'block'",
:after => "return false",
:html => { :src => '/images/button.gif', :type => 'image' }
)
%>
-
It is my opinion that button_to_remote should allow the input type to be either a button or an image since the w3c page on form input control types states that the input type image "Creates a graphical submit button." - http://www.w3.org/TR/html401/interact/forms.html#h-17.4.1
-
Hence, I have created the attached patch, that adds two test cases to javascript_helper_test.rb and one test case to prototype_helper_test.rb to illustrate the issue at hand and tests the modifications that I have placed in javascript_helper.rb
Comments and changes to this ticket
-
-
Santiago Pastorino February 2nd, 2011 @ 04:50 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:50 PM
- State changed from “open” to “stale”
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
gautam chekuri
Sweetperceptions