This project is archived and is in readonly mode.
Rename _delete to _destroy in nested attributes
-
iain
+1 the difference between destroy and delete is quite confusing, let's minimize the confusion
-
Eloy Duran
- Assigned user set to Eloy Duran
-
Eloy Duran
- State changed from new to verified
- Milestone changed from 2.x to 2.3.4
I have verified and applied this patch on my branch of 2-3-stable, which Micheal will look at and merge in before 2.3.4.
http://github.com/alloy/rails/commit/6d4637be2adee0caafcfb7d5a98837...
Thanks!
-
Repository
- State changed from verified to resolved
(from [11c338735c3f6e9562c4c82ccd8913dd8b7a6a80]) Rename nested attributes delete to destroy to reflect its actual behavior and DSL (:allow_destroy). Deprecation warning added. [#2889 state:resolved] Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/11c338735c3f6e9562c4c82ccd8913... -
Repository
(from [3091252abaafd15bc085f0be2b17829bebb6522c]) Rename nested attributes delete to destroy to reflect its actual behavior and DSL (:allow_destroy). Deprecation warning added. [#2889 state:resolved] Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/3091252abaafd15bc085f0be2b1782... -
Dudley Flanders
The commit missed a couple of comments and examples that still use the old :_delete key.
-
José Valim
Thanks for the patch, applied!
