Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

mail_to with javascript + replace_(dot|at) doesn't actually replace dots+ats

#294

This patch makes UrlHelper#mail_to replace dots and at's when the encode option is set to javascript.

If you specified :replace_dot/:replace_at options together with the :encode => "javascript" option, the encoded javascript would actually include the raw email and not the one with dots and/or at's replaced.

Attached is a tiny git-am ready patch against 3282bf3b5016f0c9028cfff1012e8c31a13b40b7 that fixes this.

Reported by Johan Sørensen · June 1st, 2008 @ 07:07 PM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Repository
    Repository
    • State changed from new to resolved
    • Tag set to actionpack, bug, patch

    (from [50b5c6845ed1645cf25613024ef04187385f8dcd]) Ensure mail_to label is obfuscated for javascript encoding. [#294 state:resolved]

    Signed-off-by: Pratik Naik

    http://github.com/rails/rails/co...

    July 12th, 2008 @ 03:01 AM

  2. Repository
    Repository

    (from [8d61eadcc6e58a28e1c4c41c707f66a5d154d14d]) Ensure mail_to label is obfuscated for javascript encoding. [#294 mail_to with javascript + replace_(dot|at) doesn't actually replace dots+ats state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    August 25th, 2008 @ 09:27 AM