This project is archived and is in readonly mode.

#2963 ✓stale
MarsuBoss

Prototype Helper

Reported by MarsuBoss | July 28th, 2009 @ 02:18 PM

Hi,

When i use the function remote_function and add the option with. It's generate : parameters:'test=test' + '&authenticity_token=' + encodeURIComponent('...') but on w3c.validator.org accept not '&'. So i try to change &authenticity_token => &authenticity_token. It's passed.

For fix this problem :

/vendor/rails/actionpack/lib/action_view/helpers/prototype_helper.rb

Line 1064 :

Before : js_options['parameters'] << " + '&"
After : js_options['parameters'] << " + '&"

Comments and changes to this ticket

  • Mike Riley

    Mike Riley July 29th, 2010 @ 02:37 PM

    • State changed from “new” to “needs-more-info”
    • Importance changed from “” to “”

    Hello,

    I took a look at this and not sure of the difference between the before and after for line 1064 that you suggested to have changed. Also, what version of Rails is this in reference? I looked at Rails 3.0 and this line number is no longer valid as the prototype_helper.rb file is much smaller now. Is this issue still valid for you? I am going to mark this as needs more info, but if you need additional help on fixing this, feel free to update this ticket or we can close it out if it is no longer a problem for you.

    Mike Riley

  • MarsuBoss

    MarsuBoss July 29th, 2010 @ 02:51 PM

    Hello,

    Line 622 :

    Before : js_options['parameters'] << " + '&"
    After : js_options['parameters'] << " + '& a m p ;" (no space for "& a m p ;")

  • rails

    rails April 9th, 2011 @ 01:00 AM

    • State changed from “needs-more-info” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails April 9th, 2011 @ 01:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages