This project is archived and is in readonly mode.
Change scaffolding to use respond_with
I've attached a patch which changes the generated scaffold controller to use the new and shiny respond_with syntax
-
José Valim- Assigned user set to José Valim
- Milestone cleared.
Hey Simon,
Nice patch. I'm still not sure if we are going to change it or not, but a few things I noticed in your patch:
1) It removes flash messages. So scaffold tests will fail after your change (flash messages should be kept);
2) I don't like the inline syntax very much. It's cleaner with one line for assignment and another to invoke respond_with.
-
Simon JeffordJosé,
Yes, you're absolutely right of course. Guess I got carried away with deleting code and missed that I was taking the flash messages out.
I'll get an updated patch attached tomorrow.
-
Simon Jefford
Here's a patch without inline assignment but with flash messages!
-
José Valim
- State changed from new to wontfix
Simon, after some discussion, we agreed that scaffold should be a learning tool. In this case, respond_with hides a lot of what is happening. For this reason, we won't change scaffold for respond_with. But thanks for working on a patch!
-
trevorany interest in including an alternate version of the scaffolding? one for learning, and one for best practices?
-
