This project is archived and is in readonly mode.
[PATCH] layouts with absolute path not found if path does not contain "layouts"
If the layout does not contain the word "layouts", it is prepended with "layouts/" even if the path is absolute which leads to a TemplateMissing error with a path like:
layouts//Users/gaspard/rails/path/to/layout.rhtml
The patch contains a failing test and a simple fix to detect absolute paths.
-
Gaspard Bucher- Tag changed from 2-3-stable, absolutepath, layouts to 2-3-stable, absolutepath, layouts, patch
-
CancelProfileIsBroken- Tag changed from 2-3-stable, absolutepath, layouts, patch to 2-3-stable, absolutepath, bugmash, layouts, patch
-
Elomar França+1, verified on 2-3-stable.
The patch does not apply to master. I think master is not affected by this bug, but I couldn't write a failing test to it.
-
Elad Meidar
+1 verified and applied cleanly on 2-3-stable. i think this is unreproducible in master, there seem to be a different implementation that amends the layouts/ prefix.
-
Blue Box Stephen
+1 verified and applied cleanly on 2-3-stable. Also, I've verified that this patch isn't necessary on master-- there's already a test_absolute_pathed_layout in master which does the exact same thing as Gaspard's test_absolute_pathed_layout_without_layouts_in_path
-
Elomar França
- Tag changed from 2-3-stable, absolutepath, bugmash, layouts, patch to 2-3-stable, absolutepath, bug, bugmash, bugmash-review, bugmash_review, layouts, patch
-
CancelProfileIsBroken
- Tag changed from 2-3-stable, absolutepath, bug, bugmash, bugmash-review, bugmash_review, layouts, patch to 2-3-stable, absolutepath, bug, bugmash-review, bugmash_review, layouts, patch
-
Repository
- State changed from new to committed
(from [8371d6f0c1948d3201c1db1fea4b1604a238d48d]) Fixes a bug where layouts provided with an absolute path would not be found because they were prefixed by 'layouts'. This bug only appears if the path does not contain the word 'layouts'.
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3207 state:committed] http://github.com/rails/rails/commit/8371d6f0c1948d3201c1db1fea4b16... -
Gaspard Bucher
Thanks to the bugmash team for this fast inclusion !
-
Rizwan Reza- Tag changed from 2-3-stable, absolutepath, bug, bugmash-review, bugmash_review, layouts, patch to 2-3-stable, absolutepath, bug, layouts, patch