This project is archived and is in readonly mode.
[PATCH] layouts with absolute path not found if path does not contain "layouts"
Reported by Gaspard Bucher | September 15th, 2009 @ 09:07 AM
If the layout does not contain the word "layouts", it is prepended with "layouts/" even if the path is absolute which leads to a TemplateMissing error with a path like:
layouts//Users/gaspard/rails/path/to/layout.rhtml
The patch contains a failing test and a simple fix to detect absolute paths.
Comments and changes to this ticket
-
Gaspard Bucher September 15th, 2009 @ 09:11 AM
- Tag changed from “2-3-stable, absolutepath, layouts” to “2-3-stable, absolutepath, layouts, patch”
-
CancelProfileIsBroken September 25th, 2009 @ 12:10 PM
- Tag changed from “2-3-stable, absolutepath, layouts, patch” to “2-3-stable, absolutepath, bugmash, layouts, patch”
-
Elomar França September 27th, 2009 @ 09:17 PM
+1, verified on 2-3-stable.
The patch does not apply to master. I think master is not affected by this bug, but I couldn't write a failing test to it.
-
Elad Meidar September 27th, 2009 @ 09:41 PM
+1 verified and applied cleanly on 2-3-stable. i think this is unreproducible in master, there seem to be a different implementation that amends the layouts/ prefix.
-
Blue Box Stephen September 27th, 2009 @ 11:45 PM
+1 verified and applied cleanly on 2-3-stable. Also, I've verified that this patch isn't necessary on master-- there's already a test_absolute_pathed_layout in master which does the exact same thing as Gaspard's test_absolute_pathed_layout_without_layouts_in_path
-
Elomar França September 28th, 2009 @ 12:44 AM
- Tag changed from “2-3-stable, absolutepath, bugmash, layouts, patch” to “2-3-stable, absolutepath, bug, bugmash, bugmash-review, bugmash_review, layouts, patch”
-
CancelProfileIsBroken September 28th, 2009 @ 01:30 AM
- Tag changed from “2-3-stable, absolutepath, bug, bugmash, bugmash-review, bugmash_review, layouts, patch” to “2-3-stable, absolutepath, bug, bugmash-review, bugmash_review, layouts, patch”
-
Repository September 28th, 2009 @ 03:29 AM
- State changed from “new” to “committed”
(from [8371d6f0c1948d3201c1db1fea4b1604a238d48d]) Fixes a bug where layouts provided with an absolute path would not be found because they were prefixed by 'layouts'. This bug only appears if the path does not contain the word 'layouts'.
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3207 state:committed] http://github.com/rails/rails/commit/8371d6f0c1948d3201c1db1fea4b16... -
-
Rizwan Reza May 15th, 2010 @ 06:42 PM
- Tag changed from “2-3-stable, absolutepath, bug, bugmash-review, bugmash_review, layouts, patch” to “2-3-stable, absolutepath, bug, layouts, patch”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Gaspard Bucher
Attachments
Referenced by
-
3207
[PATCH] layouts with absolute path not found if path does not contain "layouts"
Signed-off-by: Michael Koziarski michael@koziarski.com
[#...