From 4c9944621b872bda1e6b8501972d1867a804bc56 Mon Sep 17 00:00:00 2001 From: Lena Date: Sat, 15 May 2010 18:47:38 -0400 Subject: [PATCH] [PATCH] Allows attributes with symbol values to be used for checkboxes - Ticket 3209, includes test. Signed-off-by: Enrico Bianco --- actionpack/lib/action_view/helpers/form_helper.rb | 4 ++-- actionpack/test/template/form_helper_test.rb | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/actionpack/lib/action_view/helpers/form_helper.rb b/actionpack/lib/action_view/helpers/form_helper.rb index 414a5d4..23b7e78 100644 --- a/actionpack/lib/action_view/helpers/form_helper.rb +++ b/actionpack/lib/action_view/helpers/form_helper.rb @@ -1013,8 +1013,8 @@ module ActionView false when Integer value != 0 - when String - value == checked_value + when String, Symbol + value.to_s == checked_value.to_s when Array value.include?(checked_value) else diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index 3893d15..da80833 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -260,6 +260,16 @@ class FormHelperTest < ActionView::TestCase '', check_box("post", "secret", {}, "on", "off") ) + @post.secret = :on + assert_dom_equal( + '', + check_box("post", "secret", {}, "on", "off") + ) + @post.secret = :off + assert_dom_equal( + '', + check_box("post", "secret", {}, "on", "off") + ) end def test_check_box_with_multiple_behavior -- 1.6.4.4