Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

CGI.escape escapes characters that should be allowed in anchors in url_rewriter

#3315

In 2.3.4 CGI.escape was applied to the value supplied by :anchor in link_to and url_for.

The regex used to character encode disallowed characters in CGI::escape does not allow ? or / which are specfically allowed by the spec.

See http://tools.ietf.org/html/rfc3986#section-3.5

Reported by Roy W. Black · October 3rd, 2009 @ 12:18 AM

State: invalid
Milestone: none
Assigned to: Ryan Bigg Ryan Bigg
Importance: none

Activity

  1. David Trasbo
    David Trasbo
    • Assigned user set to Ryan Bigg

    Unrelated to Rails. http://ruby-doc.org/stdlib/libdoc/cgi/rdoc/index.html Can be marked as invalid.

    April 15th, 2010 @ 09:49 PM

  2. Ryan Bigg
    Ryan Bigg
    • State changed from new to invalid

    CGI is Ruby core.

    April 15th, 2010 @ 10:37 PM

  3. Roy W. Black
    Roy W. Black

    Then maybe CGI::escape should not be used on anchors? This was a change in behavior between 2.3.4 and 2.3.5

    April 16th, 2010 @ 02:51 AM